Review Request: Add a CMake switch for building playground

[Martin Blumenstingl]

> On Aug. 8, 2011, 6:14 p.m., Martin Blumenstingl wrote:
> >

Sorry, it seems that reviewboard ate my comment :(
Here's the original text:

Please speak up in the next few days if something speaks AGAINST committing this (otherwise I'll commit next week).
The patch itself is pretty straight forward, so there shouldn't be much wrong with it.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102077/#review5520
-----------------------------------------------------------


On July 24, 2011, 6:29 p.m., Martin Blumenstingl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102077/
> -----------------------------------------------------------
> 
> (Updated July 24, 2011, 6:29 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> It seems that up to now everyone who tried to build playground had to do evil workarounds.
> 
> Since CMake is quite nice I wrote a small fix for it.
> It's now possible to enable/disable building playground via a small CMake switch.
> By default this switch is set to OFF.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0c2e958 
>   playground/CMakeLists.txt 4cd4052 
> 
> Diff: http://git.reviewboard.kde.org/r/102077/diff
> 
> 
> Testing
> -------
> 
> The coverbling applet installs successful if playground is enabled.
> I did not test anything else (except disabling the switch again and seeing if the coverbling applet is now excluded).
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20110808/2b8d0742/attachment-0001.html>