Review Request: The Playdar Collection and related changes

[Andy Coder]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100001/
-----------------------------------------------------------

(Updated 2010-09-25 18:21:06.861866)


Review request for amarok and Leo Franchi.


Changes
-------

Ooops: I introduced a compiler error in the last revision, so I fixed it and took care of an unused parameter warning that I'd missed.


Summary
-------

This is what it does, (basically):

1) Adds the PlaydarCollection/QueryMaker/Meta/etc. code in src/core-impl/collections/playdar-collection/

2) Adds the top-level external/ directory and moves JsonQt into it

3) Changes the formerly unused side of the behavior of MetaProxy::Track,
   (when AwaitLookupNotification == false), so that PlaydarTracks can sit
   around and eventually get updated without slowing things to a crawl

4) Changes CurrentEngine and the SimilarArtists applet' use of
   CollectionManager::instance()->primaryCollection() to ->queryMaker()

5) Adds the 'Add top track to playlist' button to SimilarArtists

6) Prevents XSPFPlaylist from killing of MetaProxy::Tracks just
   because they're not playable yet


Diffs (updated)
-----

  src/core-impl/collections/playdarcollection/PlaydarCollection.cpp PRE-CREATION 
  src/core-impl/collections/playdarcollection/support/ProxyResolver.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/100001/diff


Testing
-------


Screenshots
-----------

It works! (for me)
  http://git.reviewboard.kde.org/r/100001/s/2/


Thanks,

Andy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20100925/285b7151/attachment.htm