<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100001/">http://git.reviewboard.kde.org/r/100001/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for amarok and Leo Franchi.</div>
<div>By Andy Coder.</div>
<p style="color: grey;"><i>Updated 2010-09-25 18:21:06.861866</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ooops: I introduced a compiler error in the last revision, so I fixed it and took care of an unused parameter warning that I'd missed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is what it does, (basically):
1) Adds the PlaydarCollection/QueryMaker/Meta/etc. code in src/core-impl/collections/playdar-collection/
2) Adds the top-level external/ directory and moves JsonQt into it
3) Changes the formerly unused side of the behavior of MetaProxy::Track,
(when AwaitLookupNotification == false), so that PlaydarTracks can sit
around and eventually get updated without slowing things to a crawl
4) Changes CurrentEngine and the SimilarArtists applet' use of
CollectionManager::instance()->primaryCollection() to ->queryMaker()
5) Adds the 'Add top track to playlist' button to SimilarArtists
6) Prevents XSPFPlaylist from killing of MetaProxy::Tracks just
because they're not playable yet</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/playdarcollection/PlaydarCollection.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/playdarcollection/support/ProxyResolver.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100001/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100001/s/2/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2010/09/24/ss-amarok-defaultPlaylistAndCoversLoaded_400x100.png" style="border: 1px black solid;" alt="It works! (for me)" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>