Review Request: "Album Artist" field support.

[Sergey Ivanov]

> On 2010-10-30 14:33:15, Ralf Engels wrote:
> > Is there a way in the tag-dialog to edit the album artist once it has been set by the MusicBrainz component?
> >  I haven't seen any, which would make it almost impossible for me to set it back.
> >  Also (as it currently is not really displayed anywhere) it is almost impossible to detect if it was set wrongly.
> > 
> > Next point. track->setAlbumArtist seems to change the album artist of every track in the same album.
> >  I would prefere it if a new album is created and the track moved there. This is also less code.
> > 
> > Then I haven't noticed the artist helper anywhere. Usually if the album artist is set the artist helper will change "A feat. B" into "A".
> >  On second thought that is not a bad idea.

Now, album artist could be changed only by MB Tagger, or by setting "Collection" for album/tracks (in play list pop up menu Album->"Show in Various Artists"). I just can't find place for this field on TagDialog. :)

Done.

Done. 


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100084/#review222
-----------------------------------------------------------


On 2010-10-30 17:57:02, Sergey Ivanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100084/
> -----------------------------------------------------------
> 
> (Updated 2010-10-30 17:57:02)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Some try to handle "Album Artist" data (ability to store/load It in/from file). Support of updating/setting "Album Artist" for albums in SQLCollection.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/capabilities/timecode/TimecodeEditCapability.h 286cb3f 
>   src/core-impl/capabilities/timecode/TimecodeEditCapability.cpp 9a69079 
>   src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h 7df9225 
>   src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp f3142e1 
>   src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp 2008336 
>   src/core-impl/collections/sqlcollection/CapabilityDelegateImpl.cpp 0e3578a 
>   src/core-impl/collections/sqlcollection/SqlMeta.h afdf937 
>   src/core-impl/collections/sqlcollection/SqlMeta.cpp b1a0694 
>   src/core-impl/meta/file/File.h 9ab364b 
>   src/core-impl/meta/file/File.cpp 70f2b91 
>   src/core-impl/meta/proxy/MetaProxy.h 3bae966 
>   src/core-impl/meta/proxy/MetaProxy.cpp 450cd6e 
>   src/core/capabilities/EditCapability.h ba91ef9 
>   src/core/meta/support/MetaUtility.cpp 534a61a 
>   src/dialogs/TagDialog.cpp f0e671a 
>   tests/core-impl/collections/proxycollection/TestProxyCollectionMeta.cpp 97e0281 
> 
> Diff: http://git.reviewboard.kde.org/r/100084/diff
> 
> 
> Testing
> -------
> 
> Tested as I could. Works fine.
> Found out that I have ~5 different "Best Of" albums of different artists, but not the only 1 as I thought before. :)
> 
> 
> Thanks,
> 
> Sergey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101030/a4875f9e/attachment.htm