<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100084/">http://git.reviewboard.kde.org/r/100084/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 30th, 2010, 2:33 p.m., <b>Ralf Engels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is there a way in the tag-dialog to edit the album artist once it has been set by the MusicBrainz component?
I haven't seen any, which would make it almost impossible for me to set it back.
Also (as it currently is not really displayed anywhere) it is almost impossible to detect if it was set wrongly.
Next point. track->setAlbumArtist seems to change the album artist of every track in the same album.
I would prefere it if a new album is created and the track moved there. This is also less code.
Then I haven't noticed the artist helper anywhere. Usually if the album artist is set the artist helper will change "A feat. B" into "A".
On second thought that is not a bad idea.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now, album artist could be changed only by MB Tagger, or by setting "Collection" for album/tracks (in play list pop up menu Album->"Show in Various Artists"). I just can't find place for this field on TagDialog. :)
Done.
Done. </pre>
<br />
<p>- Sergey</p>
<br />
<p>On October 30th, 2010, 5:57 p.m., Sergey Ivanov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Sergey Ivanov.</div>
<p style="color: grey;"><i>Updated 2010-10-30 17:57:02</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some try to handle "Album Artist" data (ability to store/load It in/from file). Support of updating/setting "Album Artist" for albums in SQLCollection.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested as I could. Works fine.
Found out that I have ~5 different "Best Of" albums of different artists, but not the only 1 as I thought before. :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/capabilities/timecode/TimecodeEditCapability.h <span style="color: grey">(286cb3f)</span></li>
<li>src/core-impl/capabilities/timecode/TimecodeEditCapability.cpp <span style="color: grey">(9a69079)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h <span style="color: grey">(7df9225)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp <span style="color: grey">(f3142e1)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp <span style="color: grey">(2008336)</span></li>
<li>src/core-impl/collections/sqlcollection/CapabilityDelegateImpl.cpp <span style="color: grey">(0e3578a)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlMeta.h <span style="color: grey">(afdf937)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlMeta.cpp <span style="color: grey">(b1a0694)</span></li>
<li>src/core-impl/meta/file/File.h <span style="color: grey">(9ab364b)</span></li>
<li>src/core-impl/meta/file/File.cpp <span style="color: grey">(70f2b91)</span></li>
<li>src/core-impl/meta/proxy/MetaProxy.h <span style="color: grey">(3bae966)</span></li>
<li>src/core-impl/meta/proxy/MetaProxy.cpp <span style="color: grey">(450cd6e)</span></li>
<li>src/core/capabilities/EditCapability.h <span style="color: grey">(ba91ef9)</span></li>
<li>src/core/meta/support/MetaUtility.cpp <span style="color: grey">(534a61a)</span></li>
<li>src/dialogs/TagDialog.cpp <span style="color: grey">(f0e671a)</span></li>
<li>tests/core-impl/collections/proxycollection/TestProxyCollectionMeta.cpp <span style="color: grey">(97e0281)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100084/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>