Review Request: "Append & Play" service menu entry fix.

[Leo Franchi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100103/#review216
-----------------------------------------------------------

Ship it!


Thanks for the patch, looks good! I'm committing now.

- Leo


On 2010-10-25 23:52:34, Pieter van der Kloet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100103/
> -----------------------------------------------------------
> 
> (Updated 2010-10-25 23:52:34)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> This is a bugfix for bug 229706. The Append & Play context menu is currently broken because it depends on deprecated dbus calls.
> My change does not use dbus, instead it executes amarok directly, just like it does in the other context menu entries.
> 
> 
> This addresses bug 229706.
>     https://bugs.kde.org/show_bug.cgi?id=229706
> 
> 
> Diffs
> -----
> 
>   src/amarok_append.desktop e3481c6 
> 
> Diff: http://git.reviewboard.kde.org/r/100103/diff
> 
> 
> Testing
> -------
> 
> Tested it and it works as supposed.
> 
> 
> Thanks,
> 
> Pieter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101030/a18f1245/attachment.htm