Review Request: Album::setImage uses QImage now to allow setting the image from outside the UI thread

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100104/#review215
-----------------------------------------------------------

Ship it!


This patch is great, and especially important for the MeeGo port, where we have less Video-RAM. 

Our pixmap usage is crazy high, almost as high as Plasma-Desktop... (check with "xrestop").


- Mark


On 2010-10-27 08:49:31, Ralf Engels wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100104/
> -----------------------------------------------------------
> 
> (Updated 2010-10-27 08:49:31)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Album::setImage uses QImage now to allow setting the image from outside the UI thread
> 
> 
> Diffs
> -----
> 
>   src/context/applets/currenttrack/CurrentTrack.cpp 83ed59a 
>   src/context/applets/videoclip/VideoclipApplet.cpp 771cbab 
>   src/core-impl/collections/audiocd/AudioCdMeta.h 2c0e91c 
>   src/core-impl/collections/audiocd/AudioCdMeta.cpp 861ec2d 
>   src/core-impl/collections/daap/DaapMeta.h c1be0b5 
>   src/core-impl/collections/daap/DaapMeta.cpp 64b855e 
>   src/core-impl/collections/ipodcollection/handler/IpodHandler.h 9e914c2 
>   src/core-impl/collections/ipodcollection/handler/IpodHandler.cpp 64227e1 
>   src/core-impl/collections/ipodcollection/handler/capabilities/IpodArtworkCapability.h 5299aba 
>   src/core-impl/collections/ipodcollection/handler/capabilities/IpodArtworkCapability.cpp 6bf3e64 
>   src/core-impl/collections/ipodcollection/handler/capabilities/IpodWriteCapability.h b9a3407 
>   src/core-impl/collections/ipodcollection/handler/capabilities/IpodWriteCapability.cpp 4333739 
>   src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h fa57e0a 
>   src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp f277a40 
>   src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp 0c18a26 
>   src/core-impl/collections/mediadevicecollection/handler/capabilities/ArtworkCapability.h 83cc8c4 
>   src/core-impl/collections/mediadevicecollection/handler/capabilities/ArtworkCapability.cpp b458136 
>   src/core-impl/collections/mediadevicecollection/handler/capabilities/WriteCapability.h 5143af1 
>   src/core-impl/collections/mtpcollection/handler/capabilities/MtpWriteCapability.h a4e2bfb 
>   src/core-impl/collections/mtpcollection/handler/capabilities/MtpWriteCapability.cpp 86ffa31 
>   src/core-impl/collections/playdarcollection/PlaydarMeta.h 114f0bf 
>   src/core-impl/collections/playdarcollection/PlaydarMeta.cpp 58cee34 
>   src/core-impl/collections/proxycollection/ProxyCollectionMeta.h d473792 
>   src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp f800987 
>   src/core-impl/collections/sqlcollection/SqlMeta.h b92e351 
>   src/core-impl/collections/sqlcollection/SqlMeta.cpp 6b29b6e 
>   src/core-impl/collections/upnpcollection/UpnpMeta.h 62ae794 
>   src/core-impl/meta/file/File.cpp b807cba 
>   src/core-impl/meta/stream/Stream_p.h 7601249 
>   src/core-impl/meta/timecode/TimecodeMeta.h 3518bef 
>   src/core-impl/meta/timecode/TimecodeMeta.cpp 4b39585 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.h a6c95cf 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 07ceae4 
>   src/core-impl/podcasts/sql/SqlPodcastProvider.h b650151 
>   src/core-impl/podcasts/sql/SqlPodcastProvider.cpp c45e878 
>   src/core/meta/Meta.h 1225e3c 
>   src/core/podcasts/PodcastImageFetcher.cpp 735b3d1 
>   src/core/podcasts/PodcastMeta.h 9a9bae0 
>   src/covermanager/CoverFetcher.h 3970648 
>   src/covermanager/CoverFetcher.cpp 9a8d852 
>   src/covermanager/CoverFetchingActions.cpp 6263b37 
>   src/covermanager/CoverFoundDialog.h 80c19d0 
>   src/covermanager/CoverFoundDialog.cpp 88eaac6 
>   src/scriptengine/MetaTypeExporter.cpp 3d3c9c5 
>   src/services/ServiceAlbumCoverDownloader.h 912b572 
>   src/services/ServiceAlbumCoverDownloader.cpp d9a2c4e 
>   tests/TestTrackOrganizer.cpp 7eb14a9 
> 
> Diff: http://git.reviewboard.kde.org/r/100104/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ralf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101030/f510f794/attachment.htm