<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100104/">http://git.reviewboard.kde.org/r/100104/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is great, and especially important for the MeeGo port, where we have less Video-RAM.
Our pixmap usage is crazy high, almost as high as Plasma-Desktop... (check with "xrestop").
</pre>
<br />
<p>- Mark</p>
<br />
<p>On October 27th, 2010, 8:49 a.m., Ralf Engels wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Ralf Engels.</div>
<p style="color: grey;"><i>Updated 2010-10-27 08:49:31</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Album::setImage uses QImage now to allow setting the image from outside the UI thread</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/context/applets/currenttrack/CurrentTrack.cpp <span style="color: grey">(83ed59a)</span></li>
<li>src/context/applets/videoclip/VideoclipApplet.cpp <span style="color: grey">(771cbab)</span></li>
<li>src/core-impl/collections/audiocd/AudioCdMeta.h <span style="color: grey">(2c0e91c)</span></li>
<li>src/core-impl/collections/audiocd/AudioCdMeta.cpp <span style="color: grey">(861ec2d)</span></li>
<li>src/core-impl/collections/daap/DaapMeta.h <span style="color: grey">(c1be0b5)</span></li>
<li>src/core-impl/collections/daap/DaapMeta.cpp <span style="color: grey">(64b855e)</span></li>
<li>src/core-impl/collections/ipodcollection/handler/IpodHandler.h <span style="color: grey">(9e914c2)</span></li>
<li>src/core-impl/collections/ipodcollection/handler/IpodHandler.cpp <span style="color: grey">(64227e1)</span></li>
<li>src/core-impl/collections/ipodcollection/handler/capabilities/IpodArtworkCapability.h <span style="color: grey">(5299aba)</span></li>
<li>src/core-impl/collections/ipodcollection/handler/capabilities/IpodArtworkCapability.cpp <span style="color: grey">(6bf3e64)</span></li>
<li>src/core-impl/collections/ipodcollection/handler/capabilities/IpodWriteCapability.h <span style="color: grey">(b9a3407)</span></li>
<li>src/core-impl/collections/ipodcollection/handler/capabilities/IpodWriteCapability.cpp <span style="color: grey">(4333739)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h <span style="color: grey">(fa57e0a)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp <span style="color: grey">(f277a40)</span></li>
<li>src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp <span style="color: grey">(0c18a26)</span></li>
<li>src/core-impl/collections/mediadevicecollection/handler/capabilities/ArtworkCapability.h <span style="color: grey">(83cc8c4)</span></li>
<li>src/core-impl/collections/mediadevicecollection/handler/capabilities/ArtworkCapability.cpp <span style="color: grey">(b458136)</span></li>
<li>src/core-impl/collections/mediadevicecollection/handler/capabilities/WriteCapability.h <span style="color: grey">(5143af1)</span></li>
<li>src/core-impl/collections/mtpcollection/handler/capabilities/MtpWriteCapability.h <span style="color: grey">(a4e2bfb)</span></li>
<li>src/core-impl/collections/mtpcollection/handler/capabilities/MtpWriteCapability.cpp <span style="color: grey">(86ffa31)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarMeta.h <span style="color: grey">(114f0bf)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarMeta.cpp <span style="color: grey">(58cee34)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionMeta.h <span style="color: grey">(d473792)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp <span style="color: grey">(f800987)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlMeta.h <span style="color: grey">(b92e351)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlMeta.cpp <span style="color: grey">(6b29b6e)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpMeta.h <span style="color: grey">(62ae794)</span></li>
<li>src/core-impl/meta/file/File.cpp <span style="color: grey">(b807cba)</span></li>
<li>src/core-impl/meta/stream/Stream_p.h <span style="color: grey">(7601249)</span></li>
<li>src/core-impl/meta/timecode/TimecodeMeta.h <span style="color: grey">(3518bef)</span></li>
<li>src/core-impl/meta/timecode/TimecodeMeta.cpp <span style="color: grey">(4b39585)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastMeta.h <span style="color: grey">(a6c95cf)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastMeta.cpp <span style="color: grey">(07ceae4)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastProvider.h <span style="color: grey">(b650151)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastProvider.cpp <span style="color: grey">(c45e878)</span></li>
<li>src/core/meta/Meta.h <span style="color: grey">(1225e3c)</span></li>
<li>src/core/podcasts/PodcastImageFetcher.cpp <span style="color: grey">(735b3d1)</span></li>
<li>src/core/podcasts/PodcastMeta.h <span style="color: grey">(9a9bae0)</span></li>
<li>src/covermanager/CoverFetcher.h <span style="color: grey">(3970648)</span></li>
<li>src/covermanager/CoverFetcher.cpp <span style="color: grey">(9a8d852)</span></li>
<li>src/covermanager/CoverFetchingActions.cpp <span style="color: grey">(6263b37)</span></li>
<li>src/covermanager/CoverFoundDialog.h <span style="color: grey">(80c19d0)</span></li>
<li>src/covermanager/CoverFoundDialog.cpp <span style="color: grey">(88eaac6)</span></li>
<li>src/scriptengine/MetaTypeExporter.cpp <span style="color: grey">(3d3c9c5)</span></li>
<li>src/services/ServiceAlbumCoverDownloader.h <span style="color: grey">(912b572)</span></li>
<li>src/services/ServiceAlbumCoverDownloader.cpp <span style="color: grey">(d9a2c4e)</span></li>
<li>tests/TestTrackOrganizer.cpp <span style="color: grey">(7eb14a9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100104/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>