Review Request: Last.fm: submit composer under "artist" if available

[Nicholas Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100089/
-----------------------------------------------------------

(Updated 2010-10-19 21:54:57.582750)


Review request for Amarok.


Summary
-------

Submit composer information as "artist" if available when posting to last.fm.


This addresses bug 254580.
    https://bugs.kde.org/show_bug.cgi?id=254580


Diffs
-----

  src/services/lastfm/ScrobblerAdapter.cpp 47df3e3 

Diff: http://git.reviewboard.kde.org/r/100089/diff


Testing (updated)
-------

Patch "visibly" correct.

Tests run to double check; for tracks with just composer; composer and artist; artist only. Tracks correctly sent to last.fm. There do not seem to be any unit tests for last.fm submissions, so unless you have some rule like Gecko to only take patches with tests, this can go straight in.


Thanks,

Nicholas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101019/aa2f11e2/attachment.htm