Review Request: Last.fm: submit composer under "artist" if available

[Sergey Ivanov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100089/#review137
-----------------------------------------------------------



src/services/lastfm/ScrobblerAdapter.cpp
<http://git.reviewboard.kde.org/r/100089/#comment119>

    You'll submit composer as artist even if you have artist name. It's better to check artist name first.


- Sergey


On 2010-10-19 19:16:22, Nicholas Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100089/
> -----------------------------------------------------------
> 
> (Updated 2010-10-19 19:16:22)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Submit composer information as "artist" if available when posting to last.fm.
> 
> 
> This addresses bug 254580.
>     https://bugs.kde.org/show_bug.cgi?id=254580
> 
> 
> Diffs
> -----
> 
>   src/services/lastfm/ScrobblerAdapter.cpp 47df3e3 
> 
> Diff: http://git.reviewboard.kde.org/r/100089/diff
> 
> 
> Testing
> -------
> 
> None; I need to re-install my old KDE4 dev enviroment (sorry!—will have tests run soon). Patch "visibly" correct
> 
> 
> Thanks,
> 
> Nicholas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101019/50d26701/attachment.htm