Review Request: Get FileType of SQLTracks from Database instead of File Extension

[Stefan Derkits]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100004/#review107
-----------------------------------------------------------


Patch it atm "on hold" because additional Steps are needed to make this a little bit more usefull:
-) FileType needs some Refactoring (there has to be a possibility to somehow iterate through all available FileTypes, e.g. for use in the FilterDialog) - will hopefully be available for Review soon
-) After that this Patch probably needs to be changed a little bit and it could be shipped :)
But some ToDo List for additional Work in this area, to make the Patch even much much more usefull:
-) Some (or many :) ) more supported FileTypes should be added
-) CollectionScanner should then use these additional FileTypes and not set the Filetype in the Database for everything that is not Mp3,Ogg,Flac & Mp4 to Unknown
-) And of course, if the CollectionScanner would use a MimeType Resolver instead of FileExtension based Resolvers, this whole FileType Stuff would be perfect ;)

- Stefan


On 2010-09-29 14:11:39, Stefan Derkits wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100004/
> -----------------------------------------------------------
> 
> (Updated 2010-09-29 14:11:39)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> -) Added a new Class Variable to SqlTrack to hold the FileType of a Track
> -) Retrieve FileType from Database and save it in the Class Variable
> -) Return a QString Representation of the Amarok::FileType when calling the Method SqlTrack::type()
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/sqlcollection/SqlMeta.h ee3ec21 
>   src/core-impl/collections/sqlcollection/SqlMeta.cpp 2da0333 
> 
> Diff: http://git.reviewboard.kde.org/r/100004/diff
> 
> 
> Testing
> -------
> 
> Hard to test, but the TagDialog displays the correct Filetypes
> Wanted to test it with a Testcase where FileType in Database is different then the FileExtension but realized that only certain FileExtensions are read by the CollectionScanner/TagLib :)
> So actually atm, the Code doesn't make much difference, but in my opinion this is a cleaner (and more future proof) Solution to display the Filetype then just displaying the Extension of the File
> 
> 
> Thanks,
> 
> Stefan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101017/6348a0d2/attachment.htm