<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100004/">http://git.reviewboard.kde.org/r/100004/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch it atm "on hold" because additional Steps are needed to make this a little bit more usefull:
-) FileType needs some Refactoring (there has to be a possibility to somehow iterate through all available FileTypes, e.g. for use in the FilterDialog) - will hopefully be available for Review soon
-) After that this Patch probably needs to be changed a little bit and it could be shipped :)
But some ToDo List for additional Work in this area, to make the Patch even much much more usefull:
-) Some (or many :) ) more supported FileTypes should be added
-) CollectionScanner should then use these additional FileTypes and not set the Filetype in the Database for everything that is not Mp3,Ogg,Flac & Mp4 to Unknown
-) And of course, if the CollectionScanner would use a MimeType Resolver instead of FileExtension based Resolvers, this whole FileType Stuff would be perfect ;)</pre>
<br />
<p>- Stefan</p>
<br />
<p>On September 29th, 2010, 2:11 p.m., Stefan Derkits wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Stefan Derkits.</div>
<p style="color: grey;"><i>Updated 2010-09-29 14:11:39</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">-) Added a new Class Variable to SqlTrack to hold the FileType of a Track
-) Retrieve FileType from Database and save it in the Class Variable
-) Return a QString Representation of the Amarok::FileType when calling the Method SqlTrack::type()</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hard to test, but the TagDialog displays the correct Filetypes
Wanted to test it with a Testcase where FileType in Database is different then the FileExtension but realized that only certain FileExtensions are read by the CollectionScanner/TagLib :)
So actually atm, the Code doesn't make much difference, but in my opinion this is a cleaner (and more future proof) Solution to display the Filetype then just displaying the Extension of the File</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/sqlcollection/SqlMeta.h <span style="color: grey">(ee3ec21)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlMeta.cpp <span style="color: grey">(2da0333)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100004/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>