Review Request: Add ability to hide/show menubar

Stefan Derkits stefan at derkits.at
Sun Oct 17 11:17:34 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100002/#review106
-----------------------------------------------------------

Ship it!


Looks good, ship it :)

- Stefan


On 2010-10-09 21:39:52, Valentyn Pavliuchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100002/
> -----------------------------------------------------------
> 
> (Updated 2010-10-09 21:39:52)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Add Show Menubar to both main and popup menus to allow hiding/showing menu bar.
> 
> 
> This addresses bug 210020.
>     https://bugs.kde.org/show_bug.cgi?id=210020
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.h e6ae0b3 
>   src/MainWindow.cpp 0eb6b28 
> 
> Diff: http://git.reviewboard.kde.org/r/100002/diff
> 
> 
> Testing
> -------
> 
> Tested functionality: all ok.
> 
> 
> Screenshots
> -----------
> 
> Warning dialog
>   http://git.reviewboard.kde.org/r/100002/s/4/
> Context menu
>   http://git.reviewboard.kde.org/r/100002/s/5/
> 
> 
> Thanks,
> 
> Valentyn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101017/765a6589/attachment.htm 


More information about the Amarok-devel mailing list