Review Request: Make playlist sorting breadcrumb items translatable

Alexander Potashev aspotashev at gmail.com
Sun Oct 10 07:54:31 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100053/
-----------------------------------------------------------

Review request for Amarok.


Summary
-------

The translated column names (columnNames) cannot be stored in PlaylistDefines.h, because they can only be obtained in run-time. In this patch I use a singleton class which generates a list of translated columns at the first time when it is required.


This addresses bug 189750.
    https://bugs.kde.org/show_bug.cgi?id=189750


Diffs
-----

  src/CMakeLists.txt f135a86 
  src/playlist/PlaylistBreadcrumbItem.cpp 7e0a9cd 
  src/playlist/PlaylistBreadcrumbLevel.cpp e86d455 
  src/playlist/PlaylistColumnNames.h PRE-CREATION 
  src/playlist/PlaylistColumnNames.cpp PRE-CREATION 
  src/playlist/PlaylistDefines.h 8a0713e 
  src/playlist/PlaylistModel.cpp f462dbf 
  src/playlist/layouts/LayoutEditWidget.cpp 1d87ec8 
  src/playlist/layouts/PlaylistLayoutEditDialog.cpp 686ea6b 
  src/playlist/proxymodels/SortScheme.cpp 0746559 

Diff: http://git.reviewboard.kde.org/r/100053/diff


Testing
-------


Thanks,

Alexander

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101010/12d26b64/attachment.htm 


More information about the Amarok-devel mailing list