[UI] Current state of the lyrics applet

[Rick W. Chen]

On 03 Oct 2010 00:43 +0200, Martin:
> Hi,
> 
> not sure if many of you have noticed it: but code-wise the lyrics applet is 
> far from being perfect.
> It's also missing some features that are currently hard to implement.
> For example: the lyrics from the lyrics applet are not synchronized with the 
> ones from Meta::Track::cachedLyrics (in other words: if one changes the lyrics 
> via TagDialog the old lyrics are still shown in the lyrics applet).
> 
> I tried to add code which synchronizes the lyrics from the applet with the 
> ones from the track. In theory this isn't that hard, but....
> Since the user can edit the lyrics in the applet I have to ask the user what 
> to do if the lyrics in the applet and in the track have changed at the same 
> time.
> My solution to this (until a few hours ago): I'll simply use a Plasma::Applet 
> feature - showMessage().
> Unfortunately there are issues (not on the plasma side though).
> With Qt 4.6 my changes looked like this: [0]
> Now I've updated to Qt 4.7 and there's a new form of that applet size bug 
> ([1]) back.
> Now the showMessage dialog looks like this: [2].
> 
> I went to #plasma and asked for possible solutions.
> The answer: 
> <aseigo> is the proxy widget in a layout?
> <xdarklight> no
> <aseigo> that's your issue then :)
> 
> I could probably add a layout to the current code somehow.
> The question is: does it still make sense to add code - or is rewriting the 
> applet the better option?

I'm actually in the process of adding layouts to all (except current
track) of the applets. So perhaps a rewrite if it were to be done is
better left till later.

> Advantages of a rewrite:
> -one could use more generic (plasma) functions so the layout is consistent 
> with other applications

What do you mean by this?

> -new code (usually that means better/better readable code)
> -and so on... ;)
> 
> Of course a rewrite means quite a lot of work. But I think it's worth it (if 
> the resulting applet is better than the current one :)).
> 
> What do you think of a rewrite of the lyrics applet?
> If we decide to rewrite it: what's currently missing?
> What's good about the current applet?
> 
> PS: I also wanted to add that confirmation message because of a bug report: 
> [3].
> Not adding it would mean another unsatisfied customer ;)
> 
> Regards,
> Martin
> 
> [0] http://www.abload.de/img/amarokscreenprh2.png
> [1] https://bugs.kde.org/show_bug.cgi?id=245342
> [2] http://www.abload.de/img/plasmashowmessagespve.png
> [3] https://bugs.kde.org/show_bug.cgi?id=207621

-- 
    Rick