Review Request: Create TrayIcon correctly when amarok resumes playing on startup.

[Conrad Hübler]

> On 2010-10-06 18:38:47, Kevin Funk wrote:
> > src/TrayIcon.cpp, line 162
> > <http://git.reviewboard.kde.org/r/100025/diff/2/?file=779#file779line162>
> >
> >     This is not needed. prettyNowPlaying() returns the same string if m_track == 0.
> >     
> >     Reasoning?

It should but it seems there is a bug in The::engineController()->prettyNowPlaying(). At least on my system prettyNowPlaying() returns the last played track instead of "No track playing" after the playlist ends or a manual stop of the playback.


- Conrad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100025/#review74
-----------------------------------------------------------


On 2010-10-06 16:39:53, Conrad Hübler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100025/
> -----------------------------------------------------------
> 
> (Updated 2010-10-06 16:39:53)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Trayicon shows the correct tooltip when amarok resumes playback.
> 
> 
> Diffs
> -----
> 
>   src/TrayIcon.cpp 6b99d33 
> 
> Diff: http://git.reviewboard.kde.org/r/100025/diff
> 
> 
> Testing
> -------
> 
> Testing done and it works for me.
> 
> 
> Thanks,
> 
> Conrad
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101007/5709d240/attachment.htm