Review Request: Create TrayIcon correctly when amarok resumes playing on startup.

Kevin Funk krf at gmx.de
Wed Oct 6 20:38:47 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100025/#review74
-----------------------------------------------------------



src/TrayIcon.cpp
<http://git.reviewboard.kde.org/r/100025/#comment47>

    This is not needed. prettyNowPlaying() returns the same string if m_track == 0.
    
    Reasoning?


- Kevin


On 2010-10-06 16:39:53, Conrad Hübler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100025/
> -----------------------------------------------------------
> 
> (Updated 2010-10-06 16:39:53)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Trayicon shows the correct tooltip when amarok resumes playback.
> 
> 
> Diffs
> -----
> 
>   src/TrayIcon.cpp 6b99d33 
> 
> Diff: http://git.reviewboard.kde.org/r/100025/diff
> 
> 
> Testing
> -------
> 
> Testing done and it works for me.
> 
> 
> Thanks,
> 
> Conrad
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101006/d4c4c3ba/attachment.htm 


More information about the Amarok-devel mailing list