Review Request: Allows compiling iPod collection on Kubuntu 10.10

[Leo Franchi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100012/#review62
-----------------------------------------------------------

Ship it!


Looks good! If you want, I can commit and tweak the paths on my comment, or you can update and i'll commit directly. Up to you.


cmake/modules/FindGDKPixBuf.cmake
<http://git.reviewboard.kde.org/r/100012/#comment43>

    Would be good to add /usr/local/include/foobar and ${KDE4_INCLUDE_DIR} as well so it works out of the box better for non-standard KDE installs too :)


- Leo


On 2010-10-02 18:06:25, James Duncan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100012/
> -----------------------------------------------------------
> 
> (Updated 2010-10-02 18:06:25)
> 
> 
> Review request for amarok.
> 
> 
> Summary
> -------
> 
> A packaging artifact installs the gdk-pixbuf headers at a
> non-standard location.  This should allow CMake to find them on 10.10.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2a0961c 
>   cmake/modules/FindGDKPixBuf.cmake PRE-CREATION 
>   cmake/modules/FindGdk.cmake 90687c1 
>   src/core-impl/collections/ipodcollection/CMakeLists.txt 9973564 
>   src/core-impl/collections/ipodcollection/config-gdk.h.cmake e751c03 
>   src/core-impl/collections/ipodcollection/handler/IpodHandler.h 373983f 
>   src/core-impl/collections/ipodcollection/handler/IpodHandler.cpp 3373b2c 
> 
> Diff: http://git.reviewboard.kde.org/r/100012/diff
> 
> 
> Testing
> -------
> 
> I can compile so far, but my system has gdk-pixbuf at the standard
> location.
> 
> 
> Thanks,
> 
> James
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101002/244ffc99/attachment.htm