<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100012/">http://git.reviewboard.kde.org/r/100012/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good! If you want, I can commit and tweak the paths on my comment, or you can update and i'll commit directly. Up to you.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/100012/diff/5/?file=730#file730line11" style="color: black; font-weight: bold; text-decoration: underline;">cmake/modules/FindGDKPixBuf.cmake</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">11</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">/usr/include/gtk-2.0/</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Would be good to add /usr/local/include/foobar and ${KDE4_INCLUDE_DIR} as well so it works out of the box better for non-standard KDE installs too :)</pre>
</div>
<br />
<p>- Leo</p>
<br />
<p>On October 2nd, 2010, 6:06 p.m., James Duncan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for amarok.</div>
<div>By James Duncan.</div>
<p style="color: grey;"><i>Updated 2010-10-02 18:06:25</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A packaging artifact installs the gdk-pixbuf headers at a
non-standard location. This should allow CMake to find them on 10.10.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can compile so far, but my system has gdk-pixbuf at the standard
location.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(2a0961c)</span></li>
<li>cmake/modules/FindGDKPixBuf.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>cmake/modules/FindGdk.cmake <span style="color: grey">(90687c1)</span></li>
<li>src/core-impl/collections/ipodcollection/CMakeLists.txt <span style="color: grey">(9973564)</span></li>
<li>src/core-impl/collections/ipodcollection/config-gdk.h.cmake <span style="color: grey">(e751c03)</span></li>
<li>src/core-impl/collections/ipodcollection/handler/IpodHandler.h <span style="color: grey">(373983f)</span></li>
<li>src/core-impl/collections/ipodcollection/handler/IpodHandler.cpp <span style="color: grey">(3373b2c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100012/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>