Review Request: Added support for showing compilations on Ipod

[Albert Farres]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100156/
-----------------------------------------------------------

(Updated 2010-11-18 10:01:48.658208)


Review request for Amarok.


Changes
-------

Changed boolean return on IpodHandler.cpp as Sergey has pointed. Furthermore, I've added support for writing compilations on the Ipod. Now, if you copy/move tracks from an album settled as a compilation (is under Various Artists item) on your main collection to an Ipod, these are stored in the right way so you see them under Various Artists item on Ipod devices.


Summary
-------

Compilations albums now are shown under Various Artists item on Ipod devices.


This addresses bug 207880.
    https://bugs.kde.org/show_bug.cgi?id=207880


Diffs (updated)
-----

  src/core-impl/collections/ipodcollection/handler/IpodHandler.h 07e0380 
  src/core-impl/collections/ipodcollection/handler/IpodHandler.cpp cd50661 
  src/core-impl/collections/ipodcollection/handler/capabilities/IpodWriteCapability.h fe13f76 
  src/core-impl/collections/ipodcollection/handler/capabilities/IpodWriteCapability.cpp f89100c 
  src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp d2c5248 
  src/core-impl/collections/mediadevicecollection/handler/capabilities/WriteCapability.h 8cf4012 
  src/core-impl/collections/mtpcollection/handler/MtpHandler.h 095d3fa 
  src/core-impl/collections/mtpcollection/handler/MtpHandler.cpp f93eb99 
  src/core-impl/collections/mtpcollection/handler/capabilities/MtpReadCapability.h 598ede2 
  src/core-impl/collections/mtpcollection/handler/capabilities/MtpWriteCapability.h b5c111f 
  src/core-impl/collections/mtpcollection/handler/capabilities/MtpWriteCapability.cpp e8c9834 

Diff: http://git.reviewboard.kde.org/r/100156/diff


Testing
-------

Tested with one Ipod Classic (6th gen)


Thanks,

Albert

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101118/806dd8b9/attachment.htm