Review Request: Helper Methods for FileType Enum in new Class FileTypeSupport, get Type in TagDialog from Database instead of Extension, some Code Changes as Example of the Advantage of the Helper Methods

[Stefan Derkits]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100088/
-----------------------------------------------------------

(Updated 2010-11-01 10:37:10.873207)


Review request for Amarok.


Changes
-------

corrected the information, because it's no longer a refactoring of FileType


Summary (updated)
-------

-) Created new Class with some Helper Functions
-) Changed MetaQueryWidget to use the QStringList that contains all Filetypes
-) Meta::SqlTrack.type() now gets it's Information from the Database instead of the FileExtension


Diffs
-----

  shared/FileType.h 55c80b9 
  shared/FileType.cpp PRE-CREATION 
  src/CMakeLists.txt 5f2ac9d 
  src/browsers/CollectionTreeItemModelBase.cpp c25549b 
  src/core-impl/collections/sqlcollection/CMakeLists.txt f530d67 
  src/core-impl/collections/sqlcollection/SqlMeta.h afdf937 
  src/core-impl/collections/sqlcollection/SqlMeta.cpp b1a0694 
  src/core-impl/collections/support/MemoryFilter.cpp c076494 
  src/widgets/MetaQueryWidget.cpp 99e8993 
  tests/synchronization/CMakeLists.txt e5df2df 
  utilities/collectionscanner/CMakeLists.txt 70c86d0 
  utilities/collectionscanner/CollectionScanner.cpp 033ea84 

Diff: http://git.reviewboard.kde.org/r/100088/diff


Testing
-------

Tested in the App, found no wrong Behaviour


Thanks,

Stefan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101101/7845d51e/attachment.htm