Review Request: FilenameLayoutDialogs fixes
Mark Kretschmann
kretschmann at kde.org
Mon Nov 1 08:21:50 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100122/#review246
-----------------------------------------------------------
Ship it!
Definitely makes sense. A missing QString::number() is the root of all evil.
- Mark
On 2010-10-31 18:10:12, Olivier Trichet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100122/
> -----------------------------------------------------------
>
> (Updated 2010-10-31 18:10:12)
>
>
> Review request for Amarok.
>
>
> Summary
> -------
>
> * Fix int to QString conversion (do not show garbage in the parsed %track field)
> * Align label with parsed values (UI file change)
>
>
> Diffs
> -----
>
> src/dialogs/FilenameLayoutDialog.cpp 76474b5
> src/dialogs/FilenameLayoutDialog.ui 01ac093
>
> Diff: http://git.reviewboard.kde.org/r/100122/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Olivier
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101101/f3831444/attachment.htm
More information about the Amarok-devel
mailing list