Review Request: "Album Artist" field support.

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100084/#review244
-----------------------------------------------------------

Ship it!


This is one of the top requested features currently. So, yeah, by all means, please push to mainline :)

(And add to ChangeLog too)

- Mark


On 2010-10-31 23:27:22, Sergey Ivanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100084/
> -----------------------------------------------------------
> 
> (Updated 2010-10-31 23:27:22)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Some try to handle "Album Artist" data (ability to store/load It in/from file). Support of updating/setting "Album Artist" for albums in SQLCollection.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/capabilities/timecode/TimecodeEditCapability.h 286cb3f 
>   src/core-impl/capabilities/timecode/TimecodeEditCapability.cpp 9a69079 
>   src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h 7df9225 
>   src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp f3142e1 
>   src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp 2008336 
>   src/core-impl/collections/sqlcollection/CapabilityDelegateImpl.cpp d984391 
>   src/core-impl/collections/sqlcollection/SqlMeta.h a89ad6d 
>   src/core-impl/collections/sqlcollection/SqlMeta.cpp 19b4a7e 
>   src/core-impl/meta/file/File.h 9ab364b 
>   src/core-impl/meta/file/File.cpp 70f2b91 
>   src/core-impl/meta/proxy/MetaProxy.h 3bae966 
>   src/core-impl/meta/proxy/MetaProxy.cpp 450cd6e 
>   src/core/capabilities/EditCapability.h ba91ef9 
>   src/core/meta/support/MetaUtility.cpp 534a61a 
>   src/dialogs/TagDialog.cpp f0e671a 
>   tests/core-impl/collections/proxycollection/TestProxyCollectionMeta.cpp 97e0281 
> 
> Diff: http://git.reviewboard.kde.org/r/100084/diff
> 
> 
> Testing
> -------
> 
> Tested as I could. Works fine.
> Found out that I have ~5 different "Best Of" albums of different artists, but not the only 1 as I thought before. :)
> 
> 
> Thanks,
> 
> Sergey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101101/159b877b/attachment-0001.htm