Review Request: Remove MainWindow dock layout resize hacks

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100107/#review243
-----------------------------------------------------------

Ship it!


Seems to work for me too. No issues so far. So apparently something might have been fixed upstream.

And tbh, I've started to lose track of all our various layout (QDockWidget) hacks. Removing them can only be a good thing.

- Mark


On 2010-10-31 03:20:25, Rick W. Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100107/
> -----------------------------------------------------------
> 
> (Updated 2010-10-31 03:20:25)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> This patch removes the dock resize hacks introduced in
> 8cb577dc891e13668098292f821f3a8131ced4b4, which was from the merge request
> http://gitorious.org/amarok/amarok/merge_requests/154 .
> 
> There were dock resizing issues at the time, where the sizes and ratios of
> different docks were not restored properly when maximizing and restarting
> amarok. Now, at least with the new kde/qt dependencies I'm not experiencing
> any problem of the sort.
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.cpp 9102558 
>   src/MainWindow.h 4593d47 
> 
> Diff: http://git.reviewboard.kde.org/r/100107/diff
> 
> 
> Testing
> -------
> 
> Tested with different dock arrangements:
> - maximize and unmaximize window
> - restart amarok
> - hide and unhide window
> 
> The sizes and ratios of the docks remain the same.
> 
> 
> Thanks,
> 
> Rick W.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101101/7295aa14/attachment.htm