merge request #166: fix shortcuts for actions which are added by scripts

Martin darklight.xdarklight at googlemail.com
Sun May 16 17:40:57 CEST 2010


Hi,

I know you are all very busy at the moment, but I'm still writing this email 
as I want to get my little bugfix into the next release.

Some time ago I noticed a bug with the CopySongInfo script, where the shortcut 
settings were gone after restarting amarok. The BR can be seen here: [0]

Unfortunately I had no time to fix it back then, so I forgot about it for some 
weeks.
A month ago I stumbled across my bug report again and decided to fix it.
After a few hours of debugging I finally found the cause of the bug.
Thus I fixed it (plus did some small code cleanup in the corresponding class) 
and opened a merge request: [1].

Unfortunately nobody had time yet to take a closer look at my fix.
Please note the my merge request consists of two commits:
-the first commit, which is the real fix for the bug
-the second commit, which is just code cleanup

As I wanted to make sure my fix is correct I asked dfaure what his thoughts 
about my patch would be.
I added a comment with a summary of our short discussion to the merge request 
- you can see it here: [2].

I know we are in basically all possible freezes right now ;)
Thus you may not want to merge both patches (as the second one is just code 
cleanup). But as the first patch is quite trivial (two lines of code added) it 
would be nice if you could at least commit this one (as you know: only a fixed 
bug is a good bug ;)).

Note: I CC'ed Sven and Leo as they might know more about the scripting stuff 
inside amarok. Everything else you would need to know can be read in my merge 
request.

Regards,
Martin

[0] https://bugs.kde.org/show_bug.cgi?id=223165
[1] http://gitorious.org/amarok/amarok/merge_requests/166
[2] http://gitorious.org/amarok/amarok/merge_requests/166#comment_10778


More information about the Amarok-devel mailing list