[Amarok] 366dbe7 Fix SqlTrack playcount semantics towards LastFM/FM

[Jeff Mitchell]

On 3/24/2010 11:43 AM, Bart Cerneels wrote:
> On Wed, Mar 24, 2010 at 16:24, Jeff Mitchell <mitchell at kde.org> wrote:
>> commit 366dbe78ea69d0dd194222b02ad336b8d7e38428
>> Author: Jeff Mitchell <mitchell at kde.org>
>> Date:   Wed Mar 24 11:30:43 2010 -0400
>>
>>    Fix SqlTrack playcount semantics towards LastFM/FMPS rules.
>>
>>    Max, you said that this would have to be implemented in at least two places, but unless you mean in StatisticsProvider classes (which don't know the length of a track) I didn't find another place.
>>
> 
> I think maxx meant you need to implement the semantics in the last.fm
> plugin as well. If last.fm wants it in a certain way it should be
> forced that way instead of depending on a function in amarok-core and
> expecting it to do respect last.fm semantics.

If the algorithm is put into StatisticsProvider there's no reason that a
custom provider couldn't override the semantics. So for Last.fm (which
has slightly different rules) a simple override of one class would
suffice, and the rest of Amarok would have consistent playcount counting
methodology.

--Jeff

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 196 bytes
Desc: OpenPGP digital signature
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20100324/57d8dd3a/attachment.sig