[GSoC] UPnP progress report week 6/7

[Nikhil Marathe]

On Sun, Jul 4, 2010 at 1:33 PM, Maximilian Kossick
<maximilian.kossick at googlemail.com> wrote:
> Hi Nikhil,
>
> I just had a look at the UpnpQueryMaker on gitorious and noted that it
> is always creating new Meta objects instead of returning already
> existing ones. This will break several parts of Amarok which rely on
> ponter comparison to determine equality of Meta objects.
>
> Please consider using a cache similar to SqlRegistry in SqlCollection.
> There is a class PrivateMetaRegistry in meta/support, but I would not
> recommend using that. It lacks garbage collection and has, for some
> reason, a static instance variable and no locking.

Thanks a lot for that pointer :) I will take a look at it. The
UpnpQueryMaker is pretty badly implemented right now until I can
figure out completely how all the queries are mapped and so on.

Nikhil