[Amarok] Scanner now also looks for "folder.*" as cover ima

Jeff Mitchell mitchell at kde.org
Fri Jan 22 16:03:35 CET 2010



On Jan 22, 2010, at 6:56 AM, Dan Meltzer  
<parallelgrapefruit at gmail.com> wrote:

>
> Right, but creating 40,000 qfileinfo's to scan 10,000 files is going
> to be more expensive than creating 10,000 qfileinfos to scan 10,000
> files, reguardless of the specific numbers.

Obviously.


>>
>>> More to the point, isn't amarokcollectionscanner supposed to spit  
>>> out
>>> image paths?  It's already reading everything in the filesystem,  
>>> so it
>>> would make sense for it to parse cover.blah's at the same point.
>>
>> It does spit out image paths. The scan result processor is using
>> heuristics to determine which is the best one to use. Possibly this
>> could be moved to the scanner -- the code is a bit complicated and I
>> don't know what the implications would be.
>
> If it spits out paths, then we should just do a string search rather
> than creating a qfileinfo (which needs to load at least some stuff
> from the hd, I'd assume.-- The docs are not entirely clear about how
> much is precached vs. how much is loaded on demand.

I believe the qfileinfo is being used to normalize paths.

--Jeff


More information about the Amarok-devel mailing list