Decision needed for "Move to Trash"

[Maximilian Kossick]

On Tue, Jan 19, 2010 at 2:22 PM, Mark Kretschmann <kretschmann at kde.org> wrote:
> Ahoy,
>
> Louis Bayle has made a Merge Request for adding a "Move to Trash"
> feature to the playlist context menu. It would be nice if we could
> decide on this before string freeze. Please have a look here and
> comment:
>
> http://gitorious.org/amarok/amarok/merge_requests/102
>
I'll just ignore the whole usability discussion:

First, what's up with that merge request? It looks like there's a
change to almost every single file in Amarok's source tree. Are there
any relevant changes in that first commit?

Second, it uses deletedialog, which is a relict of A1 times and has
not been used in A2 so far. It completely fails to address the (in my
opinion) important point of "moving to trash" files from a media
device or other non-local collections. What happens when you "move to
trash" files from you ipod? We *will* get bug reports like "Amarok
does not remove files from the ipod database". How do you make actions
like that reversable? (which is the whole point of a trash bin after
all)

Cheers,
Max