[Amarok] 57e87dc Fix Dynamic Collections.

Ralf Engels ralf-engels at gmx.de
Mon Aug 9 21:56:16 CEST 2010


> Date: Sun,  8 Aug 2010 22:56:31 +0000 (UTC)
> From: Jeff Mitchell <mitchell at kde.org>
> Subject: [Amarok] 57e87dc Fix Dynamic Collections.
> To: <amarok-devel at kde.org>
> Message-ID: <20100808225632.10124B5D1F7 at projects.kde.org>
> 
> commit 57e87dc0139577120a19c0f1c39f5b7fb02b002e
> Author: Jeff Mitchell <mitchell at kde.org>
> Date:   Sun Aug 8 18:50:39 2010 -0400
> 
>     Fix Dynamic Collections.
>     
>     There were three problems I could find:
>     
...

I realized that there are some additional problems:

1. SqlAlbum::setCompilation
when setting an album as a compilation it does not invalidate it.
when setting an album as no compilation it does not invalidate all
albums where tracks are getting moved to.

2. SqlTrack::setAlbum( const QString &newAlbum )
Does not check if the old album is empty and could be removed. This also
leaks image cache.

Also I am pretty sure that I don't want to do a full rescan.
Is there some way around this?

BR,
Ralf



More information about the Amarok-devel mailing list