[Amarok] Make window caption update correctly when track ch

[Mark Kretschmann]

On Thu, Oct 29, 2009 at 2:56 PM, Kevin Funk <krf at gmx.de> wrote:
>> commit 341a837f504fd1fac23108bf1b84da948484c4d9
>> Author:     Mark Kretschmann <kretschmann at kde.org>
>> AuthorDate: Thu Oct 29 11:31:28 2009 +0100
>> Commit:     Mark Kretschmann <kretschmann at kde.org>
>> CommitDate: Thu Oct 29 11:45:42 2009 +0100
>>
>>     Make window caption update correctly when track changes.
>>
>>     Sometimes (for no apparent reason) the caption keeps staying in stopped
>>     mode. I dunno why, but we'll figure it out eventually.
>
> By the way, when loading LastFM tracks the window captions flickers two or
> three times...
> I guess that's because of "stoppedstate -> loadingstate -> bufferingstate ->
> playliststate" or somewhat.
> Maybe we can find a way to prevent it from doing that, doesnt look that nice.

Yeah, we can simply not call metadataChanged( m_currentTrack ) then.
It's there because I wondered why the caption sometimes stays "Amarok"
although it's playing.

That said, our whole Engine/Metadata observing system is a bit messy.
You kinda have to guess what to use for each case. Most classes use a
mix of EngineObserver  and Meta::Observer methods. It would be nice to
have just one way to do this, without guessing every time. Then also
add some Phonon bugs into the mix, to make the confusion complete.

-- 
Mark Kretschmann
Amarok Developer
www.kde.org - amarok.kde.org