[Bug 195013] flat-view flat view collection

Maximilian Kossick maximilian.kossick at googlemail.com
Thu Oct 29 11:38:20 CET 2009


On Thu, Oct 29, 2009 at 11:32 AM, Bart Cerneels <bart.cerneels at kde.org> wrote:
> A flat view, or rather an iTunes like 3 panel browser, is a feature
> request from my girlfriend. I only thought it would be difficult
> because I'm unfamiliar with QueryMaker and the way it interacts with
> QAbstractItemModel.
>
> It's sort of a feature I would do if no one else does and I happen to
> have some time.
> Obviously, that last one is unlikely so I was happy to read in the bug
> report Maxx was working on it. But I think the all-collection and a
> different browsing mode were mixed up.
>
> Bart

Yep, unified mode (don't show collections separately) != flat mode.
Although the basis for unified mode, ProxyCollection, can be reused
for the flat mode. Implementing a flat mdoe should be relatively easy
as you do not have to handle filtering in the tree model with
unexpanded nodes (lots of fun let me tell you). It would basically
consist of running a querymaker with QueryMode::Track and displaying
each track as one row. A tablemodel is really simple compared to a
treemodel.



> On Thu, Oct 29, 2009 at 11:15, Myriam Schweingruber
> <schweingruber at pharma-traduction.ch> wrote:
>> ---------- Forwarded message ----------
>> From: Maximilian Kossick <maximilian.kossick at googlemail.com>
>> Date: Thu, Oct 29, 2009 at 10:37
>> Subject: [Bug 195013] flat-view flat view collection
>> To: amarok-bugs-dist at kde.org
>>
>>
>> https://bugs.kde.org/show_bug.cgi?id=195013
>>
>>
>> Maximilian Kossick <maximilian.kossick at googlemail.com> changed:
>>
>>           What    |Removed                     |Added
>> ----------------------------------------------------------------------------
>>                 CC|maximilian.kossick at googlema |
>>                   |il.com                      |
>>
>>
>>
>>
>> --- Comment #4 from Maximilian Kossick <maximilian kossick googlemail
>> com>  2009-10-29 10:37:02 ---
>> Huh? Nobody is working on that in 2.2 as ar as I know. Should be relatively
>> simple to implement though, it's simply a table view which shows one track per
>> row. I'm not quite sure why Bart thinks that it's hard to do.
>>
>> If nobody works on it, then I really wonder why there is a "Toggle
>> Flat View button in Amarok 2.2. This is BTW also associated to another
>> bug:
>>
>> https://bugs.kde.org/show_bug.cgi?id=206445
>>
>> Any input on this would be welcome. If there is a FlatView button and
>> it only crashes, then we should disable this IMHO, since nobody works
>> on it.
>>
>>
>> Regards, Myriam
>>
>>
>> PS. Maximilian, if you don't want me to subscribe you to bugs, just
>> say it, you wouldn't be the only one. But till now it has been quite
>> efficient to subscribe devs to the bugs related to their field of
>> work, since those don't get forgotten anymore. And there were a lot of
>> forgotten bugs when I started triaging...

No, subscribing me to bugs is useful. It's just that I do not have
anything to do with a "flat view mode". Apparently you confused it
with the unified mode, which I'm working on (and the race condition
causing the crashes should be fixed btw)

>> --
>> Protect your freedom and join the Fellowship of FSFE:
>> http://www.fsfe.org
>> Please don't send me proprietary file formats,
>> use ISO standard ODF instead (ISO/IEC 26300)
>> _______________________________________________
>> Amarok-devel mailing list
>> Amarok-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/amarok-devel
>>
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel at kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel
>


More information about the Amarok-devel mailing list