[Amarok] Set Last.fm's avatar size in its TreeModel and use

Rick W. Chen stuffcorpse at archlinux.us
Tue Oct 13 18:05:26 CEST 2009


Tue, 13 Oct, 2009 at 11:23:30 AM -0400, Leo Franchi:
> On Tuesday 13 October 2009 03:27:04 Rick W. Chen wrote:
> > commit 44fcac964028a2c1219bb7b33c2d1ac467bf8167
> > Author:     Rick W. Chen <stuffcorpse at archlinux.us>
> > AuthorDate: Thu Oct 8 21:24:18 2009 +1300
> > Commit:     Rick W. Chen <stuffcorpse at archlinux.us>
> > CommitDate: Tue Oct 13 19:57:02 2009 +1300
> > 
> >     Set Last.fm's avatar size in its TreeModel and use it elsewhere
> > 
> >     This fixes Last.fm's avatar display size which was inconsistent
> >     and caused cropping.
> > 
> 
> This doesn't seem to work here. It just makes the avatar really tiny, e.g. 
> very difficult to actually see.
> 
> http://imagebin.ca/view/7dN0xr.html

I think the problem here is caused by the size the avatar used to be
stored / displayed at. Previously, the avatar is first fetched from
last.fm and scaled to 48x48. Then when it is displayed the size is set
to 32x32, _without_ being scaled first.

The result is an apparently bigger image with cropping. With your
avatar there are some black space on either side so I suspect the
square cropping didn't cause anything to look suspicious.

The aim of the patch was to fix the cropping; I chose 32x32 for
everything because it was what it used to display at. Perhaps we could
increase the size?

-- 
    Rick


More information about the Amarok-devel mailing list