Fwd: [Amarok] use OS X keychain instead of KWallet provide an ab

[Mark Kretschmann]

I'm forwarding this because the commits list (or commit filter) seems
to be eating reply mails. Please always CC amarok-devel for now.

(Anyone know why this happens?)


---------- Forwarded message ----------
From: Mark Kretschmann <kretschmann at kde.org>
Date: Mon, Oct 5, 2009 at 1:38 PM
Subject: Re: [Amarok] use OS X keychain instead of KWallet provide an ab
To: kde-commits at kde.org
Cc: Maximilian Kossick <maximilian.kossick at googlemail.com>


On Sat, Sep 12, 2009 at 12:54 PM, Maximilian Kossick
<maximilian.kossick at googlemail.com> wrote:
> commit f4b29f928a944288f04993191d62ca31813fc206
> Author:     Maximilian Kossick <maximilian.kossick at googlemail.com>
> AuthorDate: Sat Sep 12 12:47:04 2009 +0200
> Commit:     Maximilian Kossick <maximilian.kossick at googlemail.com>
> CommitDate: Sat Sep 12 12:48:56 2009 +0200
>
>    use OS X keychain instead of KWallet
>    provide an abstraction layer that allows Amarok to use the OS X keychain instead of KWallet on OS X
>    not actually used anywhere yet, that should probably wait till after 2.2

Max, when you ported LastFmServiceConfig to use your CredentialStorage
class, you didn't port the code for handling non-KWallet systems. In
result, on systems without KWallet (e.g. disabled), Last.fm doesn't
work at all.


-- 
Mark Kretschmann
Amarok Developer
www.kde.org - amarok.kde.org