2.1 beta 1

[Enrico Ros]

The mouse press on stuff like the CoolStreams list is broken at 
CollectionTreeView.cpp:242, on:

    if( index.isValid() && !index.parent().isValid() ) // root item
        setExpanded( index, !isExpanded( index ) );

there, the condition is met *even* on for stuff like the Cool Streams 
collection (they should be selected by a mouse click, not "expanded").
The expansion is for the top-level items in the Local Collection, I think, 
unfortunately it breaks other CollectionTreeView usages.
I really don't know how to fix it ;-)

Also notice that the base invocation:

    // propagate to base class
    else
        QTreeView::mousePressEvent( event );

should be changed to:
        Amarok::PrettyTreeView::mousePressEvent( event );

Enrico

On Monday 23 March 2009 11:23:57 Nikolaj Hald Nielsen wrote:
> > First of all, Nikolaj _can_ reproduce this double-clicking problem,
> > but only in one specific service. But now I'm also getting other
> > problems in the Service browser (all event handling related), e.g. I
> > can no longer use the "Cool-Streams" script properly:
>
> Not quite accurate. I can reproduce it on the toplevel items in any
> collection. For instance Ampache Artist, Magnatune genres, the entire
> Local Collection, or Cool Streams tracks.
>
> Actually, a while back it was possible to add the entire Local
> Collection or an entire Magnatune Genre just by double clicking. I
> think it makes sense to allow this.
>
> - Nikolaj
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel at kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel