Opening external browsers

Seb Ruiz ruiz at kde.org
Mon Mar 9 02:03:48 CET 2009


2009/3/9 Sven Krohlas <sven at asbest-online.de>:
> Heya,
>
> at CeBIT we realized that opening a link in the Wikipedia applet
> doesn't work on Windows. So I had a look at the code.
>
> The attached patch changes the code for opening external browsers
> a lot. Currently we have Amarok::invokeBrowser() and, tbh, I didn't
> get why we need that at all. I changed the only user of it (the
> Wikipedia applet) to QDesktopServices::openUrl().
>
> This should work cross platform, removes a lot of code and saves
> us an option from the settings.
>
> As I'm not sure that I simply might have missed something: here
> it is for discussion. :)

Does this respect the user choices for the default KDE web browser? If
I change this in kde system settings I expect Amarok to respect this
choice.

> --
> Darkerradio Free Music Charts:
> http://www.darkerradio.com/news/free-music-charts-februar-2009/
>
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel at kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel
>
>



-- 
Seb Ruiz

http://www.sebruiz.net/
http://amarok.kde.org/


More information about the Amarok-devel mailing list