extragear/multimedia/amarok/src/collection/sqlcollection

Seb Ruiz ruiz at kde.org
Tue Jun 23 02:03:17 CEST 2009


2009/6/22 Jeff Mitchell <mitchell at kde.org>:
> SVN commit 985235 by mitchell:
>
> Clean images table when doing a full scan.  As far as I can tell this is an oversight, and not on purpose.

Yep, it is an oversight. Regardless, we need to fix the lack of
"retention of image properties" for albums in our database. If I set
custom artwork or unset automatically scanned art, then these changes
will be lost when rescanning.

This is one of the things that I'd like to discuss at Akademy. The
main problem is when we bump db versions at upgrade and suddenly users
lose a lot of information due to the forced rescan.

>
>
>  M  +1 -0      ScanManager.cpp
>
>
> --- trunk/extragear/multimedia/amarok/src/collection/sqlcollection/ScanManager.cpp #985234:985235
> @@ -536,6 +536,7 @@
>     m_collection->query( "DELETE FROM composers;" );
>     m_collection->query( "DELETE FROM albums;" );
>     m_collection->query( "DELETE FROM artists;" );
> +    m_collection->query( "DELETE FROM images;" );
>  }
>
>  void
>



-- 
Seb Ruiz

http://www.sebruiz.net/
http://amarok.kde.org/


More information about the Amarok-devel mailing list