extragear/multimedia/amarok/src/collection/sqlcollection

[Jeff Mitchell]

Mark Kretschmann wrote:
> Ok, now that Jeff's new code is checked in, we're having side effects:
> Amarok is crashing on exit after aborting a scan.

I tested this situation, and didn't experience it.  If you can let me
know exactly how to reproduce it, it will help.

> So that's possibly fixable with an additional check. And then maybe
> another one. Which solution appears more drastic now? ;)

Mine.  Your fix was paving over problems in the code (non-checked
pointers and the like) with a solution that would have introduced
further complexity for later debugging, not to mention increasing
overhead.  My solution uses code that was already in ScanManager, fixes
bugs in ScanManager that we might have run into later, plus found a
whole bunch of other lacking pointer safety at the same time.  Overall,
fixing bugs is better than pretending they don't exist.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20090609/4efe6919/attachment.sig