Acoustic Similarity Code Review

[Seb Ruiz]

You don't actually need me to create the review - just simpply create
a review, upload the patch and you should be good!

On 05/07/2009, Ian Monroe <ian.monroe at gmail.com> wrote:
> On Sat, Jul 4, 2009 at 6:30 PM, Soren Harward<stharward at gmail.com> wrote:
>> On Fri, Jul 3, 2009 at 5:40 PM, Ian Monroe<ian.monroe at gmail.com> wrote:
>>> Ah sorry I confused things. I meant the second commit you were going
>>> to make, that would actually do something with the similarity data.
>>
>> Ah, I see.  Yes, I'll definitely put the playlist generator patch up
>> on Fisheye before committing it, but it's not nearly as invasive, so
>> reviewing it will be much easier.
>
> Well the code review might be easier, but we also need to discuss the
> feature itself in detail (especially the UI).
>
>> Or hopefully we'll have gitorious
>> running at that point (is anyone still using Jeff's server?  I could
>> figure out how to upload it there instead), so that the code can be
>> reviewed by compiling and running it, rather than just eyeballing it.
>
> Yea Jeff's git server would work as a way for people to easily try it
> out. Send a patch to Seb and he could get it on Fisheye to do the code
> review.
>
> Ian
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel at kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel
>


-- 
Seb Ruiz

http://www.sebruiz.net/
http://amarok.kde.org/