Configurable layout in Kopete

[Seb Ruiz]

2009/2/25 Roman Jarosz <kedgedev at gmail.com>:
> On Tue, 24 Feb 2009 09:50:19 +0100, Nikolaj Hald Nielsen
> <nhnfreespirit at gmail.com> wrote:
>
>>> Hi Roman,
>>> Good to know that you're using our code. I can't see any reason to not
>>> make the above changes where relevant and appropriate. However, if
>>> you're already working with it, then it would be best if you could
>>> simply send a patch which addresses these issues (as you've probably
>>> already made these changes locally).
>>
>> I agree with Seb. All of your suggestions seem reasonable. Just send
>> us a patch, and if it does not break anything, I will commit it.
>>
>> - Nikolaj
>
> Here's the patch, the only thing which has left, is to make
> "application/x-amarok-tag-token" runtime configurable
> (will make second patch later).

I don't think it is necessary to make this a runtime configure. Simply
move it into a #define or static QString.

>
> Is it ok to commit?
>
> Roman
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel at kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel
>
>



-- 
Seb Ruiz

http://www.sebruiz.net/
http://amarok.kde.org/