Configurable layout in Kopete

Nikolaj Hald Nielsen nhnfreespirit at gmail.com
Tue Feb 24 21:06:38 CET 2009


Looks fine to me, go ahead and commit! :-)

Once it has matured for a while, we might want to look in to adding
some of this to kdelibs.

- Nikolaj

On Tue, Feb 24, 2009 at 6:40 PM, Roman Jarosz <kedgedev at gmail.com> wrote:
> On Tue, 24 Feb 2009 09:50:19 +0100, Nikolaj Hald Nielsen
> <nhnfreespirit at gmail.com> wrote:
>
>>> Hi Roman,
>>> Good to know that you're using our code. I can't see any reason to not
>>> make the above changes where relevant and appropriate. However, if
>>> you're already working with it, then it would be best if you could
>>> simply send a patch which addresses these issues (as you've probably
>>> already made these changes locally).
>>
>> I agree with Seb. All of your suggestions seem reasonable. Just send
>> us a patch, and if it does not break anything, I will commit it.
>>
>> - Nikolaj
>
> Here's the patch, the only thing which has left, is to make
> "application/x-amarok-tag-token" runtime configurable
> (will make second patch later).
>
> Is it ok to commit?
>
> Roman
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel at kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel
>
>


More information about the Amarok-devel mailing list