Configurable layout in Kopete
Roman Jarosz
kedgedev at gmail.com
Tue Feb 24 09:13:44 CET 2009
Hi,
I would like to ask you if you could change some things in layout
classes to make it more standalone, the classes which I use in Kopete
(and would like to use without any/or small changes) are DragStack.h,
FilenameLayoutWidget.h, Token.h, TokenListWidget.h and TokenWithLayout.h)
Here are the things which I would like you to change:
1. In TokenListWidget please remove filenamelayoutdialog.h (it's unused)
2. Could "application/x-amarok-tag-token" be runtime configurable or
at least be in one place?
3. Could you use DragStack instead of LayoutEditWidget in TokenWithLayout
as LayoutEditWidget calls DragStack anyway.
(at first looks this shouldn't be a problem)
The code is:
// this should really not be done here as it makes upward assumptions
// it was however done in setWidth with similar upward assumptions as
well
// solution: the popup stuff -iff- should be done in the dialog or
the
editWidget
if ( parentWidget() )
if ( Playlist::LayoutEditWidget *editWidget =
qobject_cast<Playlist::LayoutEditWidget*>( parentWidget()->parentWidget()
) )
4. There is also Amarok specific Debug.h include, would be great if you
could avoid this but I can live with it.
Regards,
Roman
PS. CC me because I'm not on the list.
More information about the Amarok-devel
mailing list