extragear/multimedia/amarok/src

[Ian Monroe]

On Mon, Feb 2, 2009 at 7:44 PM, Dan Meltzer
<parallelgrapefruit at gmail.com> wrote:
> On Mon, Feb 2, 2009 at 8:38 PM, Ian Monroe <ian.monroe at gmail.com> wrote:
>> On Mon, Feb 2, 2009 at 5:44 PM, Dan Meltzer
>> <parallelgrapefruit at gmail.com> wrote:
>>> SVN commit 920478 by dmeltzer:
>>>
>>> Fix tracks being counted twice, and track playback in the engine controller.
>>>
>>> The enginecontroller is a mess.  This commit fixes things for me (which probably breaks things for at least one other person...)
>>>  Remove slotPrefinishMarkReached (which only called slotAboutToFinish) as it resulted in duplicate stat calculation.  Also,
>>> Phonon::MediaSource can have remote media enqueued, and in fact needs to to make playback work for http/lastfm streams. Please
>>> give this some testing and if it doesn't break anything I'll backport it to stable in a few days
>>
>> There was a reason they were specifically not queued and thus left out
>> of the whole gapless playback scheme. Seems like they had odd
>> playback.
>
> Well, they had 0 chance of being played back now if aboutToFinish was
> called (and responded to) before the track actually finished, which is
> completely possible (and prevented me from listening to more than one
> http track at a time).  This method results in proper playback, and
> people who had proper playback before have not yet reported
> regressions (though I'm still waiting :) )
>

Ok I don't doubt you. EngineController is a shifty beast.

I'll update and fire up some Ampache tracks. :)

Ian