[Amarok] Clean up the EngineController logic.

Mark Kretschmann kretschmann at kde.org
Sun Aug 23 11:41:12 CEST 2009


On Sat, Aug 22, 2009 at 5:01 PM, Mark Kretschmann<kretschmann at kde.org> wrote:
> On Sat, Aug 22, 2009 at 4:40 PM, Edward Hades<edward.hades at gmail.com> wrote:
>> Alex, looks like you've hit two sparrows with single commit there ;)
>>
>> For me and Markey, Ogg Vorbis streams do not play (like in progress
>> bar moves, but there is no sound), but when you hit stop, it fades out
>> (as pointed out by Markey: "like a zombie sound from hell").
>>
>> Could you please check and look into it?
>
> And then there still is the issue with broken metadata:
>
> https://bugs.kde.org/show_bug.cgi?id=199327
>
>
> Is this "clean up" worth the breakage? Someone has to fix it, after all.

commit 31c784de15fb902d83fb5fa7ea90eafb3e191522
Author: Mark Kretschmann <kretschmann at kde.org>
Date:   Sun Aug 23 11:09:40 2009 +0200

    Revert "Clean up the EngineController logic."

    This reverts commit 28b3e64d1dc5c7170d7b5d09e6cb4c8b3cdd4e02.

    I'm temporarily reverting this commit (discussed with other devs).
    Reasons: Breaks Ogg playback, breaks metadata propagation.

    Alex, please feel free to commit this patch again when these issues
    have been resolved. In light of the upcoming Alpha release the
    breakage is too severe at this point.

-- 
Mark Kretschmann
Amarok Developer
www.kde.org - amarok.kde.org


More information about the Amarok-devel mailing list