extragear/multimedia/amarok/src/servicebrowser/lastfm

[Maximilian Kossick]

IIRC radio 2.0 is based on playlists, which means we'll end up having
the same problem as in the shoutcast browser. And all those ideas
about "expanding tracks that are actually playlists" sound like hacks
to solve a problem that was created by using the framework, in
particular the collection view, for stuff it was *really* not designed
to do. While the framework could probably be extended (Bart said that
he wants to integrate playlists into the Meta framework, and we should
talk about that one of these days), the collection view is not
designed to handle it, and should *not* be changed. The code is
difficult enough, and we should try not to make it anymore complex.

Maybe you could outline, better here than on irc, what exactly should
go into the tree view of the last.fm service. If it's anything like
the like the official client (i mean the tree view on the left), a
custom view and model are a better solution.

On Sun, Mar 2, 2008 at 10:20 AM, Nikolaj Hald Nielsen
<nhnfreespirit at gmail.com> wrote:
> > Hmm, actually i was thinking about that. It's probably a bad idea to
>  >  make everything fit the collection framework just so that we can
>  >  resuse the collection view. So you might want to implement a custom
>  >  view/model instead of twisting last.fm to fit the collection
>  >  framework.
>
>  While that might be true in some cases, I really dont think it is
>  needed here. The last.fm service service will, IMO, work just fine on
>  a MemoryCollection, which gives us searching for free.
>
>  - Nikolaj
>