[Patch] implement SqlMeta::updateImage()

Maximilian Kossick mkossick at gmx.de
Mon Nov 19 09:07:42 CET 2007


On Monday 19 November 2007, Dan Meltzer wrote:
> Yo,
>
> I got around to porting to covermanager today, only to find out that
> the code wasn't around yet to set an image for an album.  I put
> together this patch to do so.  It basically just copies the code from
> findAmazonAlbum except ends by saving instead of by loading.  I chose
> a QPixmap instead of a QImage as the parameter mostly by random,
> though it seemed to be more common to deal with.
>
> It seems to me it would also make sense to rename updateImage() to
> setImage().. any thoughts on that?  Also, should updateImage generate
> the cached file or should that be up to the image loader?
>
> Dan,

A QImage makes more sense here, because we are not going to show the image 
that we pass to updateImage on the screen in that method.

I agree to renaming updateImage. I have no idea why I chose updateImage, but 
setImage is a better name.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20071119/4e7866a1/attachment.pgp 


More information about the Amarok-devel mailing list