Fwd: branches/stable/extragear/multimedia/amarok/src

[Seb Ruiz]

---------- Forwarded message ----------
From: simon <s7mon at web.de>
Date: 8 Nov 2007 09:36
Subject: Re: branches/stable/extragear/multimedia/amarok/src
To: Amarok Mailing List <amarok at kde.org>


Hi there

i did a update to current svn (stable) today and afterwards my
collection didn't appear. I changed back to r732635 (the one before this
commit) and everything was there again ( i only had to adapt the files
scanned while using the new one - they where missing the boolean for
sampler.

While i was on the new one i got following debug output from amarok

FAILED QUERY: SELECT statistics.percentage FROM statistics  WHERE t AND
( f OR statistics.url = '.somepathonmydisk' AND statistics.deviceid = 12
OR statistics.url = '.somepathonmydisk' AND statistics.deviceid =
-1  ) ;
amarok:     [CollectionDB] POSTGRESQL QUERY FAILED: ERROR:  column "t"
does not exist
amarok:
amarok: FAILED QUERY: SELECT statistics.rating FROM statistics  WHERE t
AND ( f OR statistics.url = '.somepathonmydisk' AND statistics.deviceid
= 12  OR statistics.url = '.somepathonmydisk' AND statistics.deviceid =
-1  ) ;
amarok:     [CollectionDB] POSTGRESQL QUERY FAILED: ERROR:  column "t"
does not exist
amarok:
amarok: FAILED QUERY: SELECT statistics.percentage FROM statistics
WHERE t AND ( f OR statistics.url = '.somepathonmydisk.mp3' AND
statistics.deviceid = 12  OR statistics.url = '.somepathonmydisk.mp3'
AND statistics.deviceid = -1  ) ;
amarok:     [CollectionDB] POSTGRESQL QUERY FAILED: ERROR:  column "t"
does not exist

I'm aware these changes where made to get it working a ubuntu version,
maybe there was a newer/older postgresql version installed. Or this can
be influenced on postgresql (if so let me know).

I'm using gentoo with postgresql 8.1.9
If you need more input/testing or a bug report i can do so next weekend.

Thanks a lot for amarok!

Greetings, s|mon



On Tue, 2007-11-06 at 09:47 +0000, Seb Ruiz wrote:
> SVN commit 733429 by seb:
>
> Use "t" and "f" for postgres boolean values. Whilst psql will happily accept any truthy or falsy value as a boolean input, it will return either a 't' or 'f'. This meant that all boolean comparisons returned false when comparing against "true". Fixes forgetful settings for the podcast channels and episodes.
> CCMAIL: amarok at kde.org
>
>
>  M  +2 -2      collectiondb.h
>
>
> --- branches/stable/extragear/multimedia/amarok/src/collectiondb.h #733428:733429
> @@ -251,8 +251,8 @@
>                    string.replace( '\'', "''" );
>          }
>
> -        QString boolT() const { if (getDbConnectionType() == DbConnection::postgresql) return "true"; else return "1"; }
> -        QString boolF() const { if (getDbConnectionType() == DbConnection::postgresql) return "false"; else return "0"; }
> +        QString boolT() const { if (getDbConnectionType() == DbConnection::postgresql) return "t"; else return "1"; }
> +        QString boolF() const { if (getDbConnectionType() == DbConnection::postgresql) return "f"; else return "0"; }
>          //textColumnType should be used for normal strings, which need to be compared
>          //either case-sensitively or -insensitively
>          QString textColumnType( int length=255 ) const { if ( getDbConnectionType() == DbConnection::postgresql ) return "TEXT"; else return QString("VARCHAR(%1)").arg(length); }
> _______________________________________________
> Amarok mailing list
> Amarok at kde.org
> https://mail.kde.org/mailman/listinfo/amarok

--

Greetings,
s|mon           mailto: s7mon at web.de

_______________________________________________
Amarok mailing list
Amarok at kde.org
https://mail.kde.org/mailman/listinfo/amarok


-- 
Seb Ruiz

http://www.sebruiz.net/