[Fwd: Re: [PATCH] [RFC] Gigabeat S support / mtpmediadevice tweaks]

[Jeff Mitchell]

CCing the list.  Anyone have an opinion one way or the other?

--Jeff

-------- Original Message --------
Subject: 	Re: [PATCH] [RFC] Gigabeat S support / mtpmediadevice tweaks
Date: 	Wed, 7 Nov 2007 17:02:58 -0600
From: 	Andrew Rodland <arodland at comcast.net>
To: 	Jeff Mitchell <kde-dev at emailgoeshere.com>
References: 	<200711062116.59194.arodland at comcast.net>
<200711071320.03028.arodland at comcast.net>
<473214BC.6030703 at emailgoeshere.com>



On Wednesday 07 November 2007 01:40:44 pm you wrote:
> Andrew Rodland wrote:
> > On Wednesday 07 November 2007 01:03:23 pm you wrote:
> >> Andrew Rodland wrote:
> >>> I misspoke, I meant that the album title on the device doesn't equal
> >>> the _ album title_ in the collection (because we stuffed a disc number
> >>> string into it). As such comparisons between the two of them will screw
> >>> up unless we mangle the local album title for comparison in the same
> >>> way that we mangled the title for sending to the device.
> >>
> >> Do comparisons between the two ever happen?
> >
> > Yes, in getOrCreateAlbum (we use an album object from the device if
> > there's a match for title and create a new one if not).
>
> Personally, I long ago amended my album titles to include disc numbers,
> i.e. for artist Ibiza:
> The History of Chillout (Disc 1)
> The History of Chillout (Disc 2)
> The History of Chillout (Disc 3)
>
> So I have no problems.
>
> But thinking about this more, I think that this is something you should
> either deal with or fix on your side.  Many metadata standards -- for
> instance, the "suggested" fields for Vorbis/FLAC comments -- do not
> contain discnumber, and as a standard that other applications and audio
> players would understand, they may see a DISCNUMBER vorbiscomment field,
> but not be aware of anything special to do with it.  Even the TPOS frame
> defined for ID3 tags is a little ambiguous: you can have 1, or 1/3.
>
> So I don't think that changing this, at least as a default behavior, is
> the right thing to do, when it's working for the majority of people out
> there.  I'd encourage you to instead tag your albums with the disc info
> in your collection, which will hold up better across various formats
> anyways.
>
I don't agree. Amarok handles discnumber very nicely with the formats that I 
use, I like managing albums as single units, I don't use any other player (at 
least not in a "tag-aware" fashion), and the disc number isn't part of the 
album title, so putting it there is "wrong". But I'm not going to fight over 
it :)