Review Request 113347: allow the users to login with discourse 0.9.7

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113347/#review41976
-----------------------------------------------------------


This review has been submitted with commit d4a22b2a40fdbb022e8948814c4af9a9e989aba4 by Giorgos Tsiapaliokas to branch master.

- Commit Hook


On Oct. 19, 2013, 10:09 a.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113347/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2013, 10:09 a.m.)
> 
> 
> Review request for Bodega.
> 
> 
> Repository: bodega-server
> 
> 
> Description
> -------
> 
> With discourse 0.9.7 the bodega users aren't able to login anymore.
> The patch fixes the issue.
> 
> 
> Diffs
> -----
> 
>   sql/discourse.plsql fdc0f01 
> 
> Diff: http://git.reviewboard.kde.org/r/113347/diff/
> 
> 
> Testing
> -------
> 
> This one is tricky in order to reproduce it.
> There are 2 use cases which end up with a complete different result.
> 
> ======> Use case 1 (discourse works)
> You used to have a discourse installation of github.com/terietor/discourse and
> then you updated the installation to github.com/aseigo/discourse and it works.
> It works because terietor's discourse had written the write values in the table users.
> So when some columns moved from the users table to the user_stats table your database
> had the *right* values.
> 
> =====> Use case 2 (discourse fails)
> You *don't* have an existing discourse installation and you setup github.com/aseigo/discourse.
> You start the whole process from the begin and your users fail to login due to the "days_visited"
> error. Why? Unlike the first use case the users table *doesn't* contain the columns of the user_stats table
> so the user_stats table it never gets populated. Discourse assumes that the table contains the right values
> and when the code is being executed the object is nill(NULL) so it fails.
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20131019/06c0ed38/attachment-0001.html>