<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113347/">http://git.reviewboard.kde.org/r/113347/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit d4a22b2a40fdbb022e8948814c4af9a9e989aba4 by Giorgos Tsiapaliokas to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On October 19th, 2013, 10:09 a.m. UTC, Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Bodega.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Oct. 19, 2013, 10:09 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
bodega-server
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">With discourse 0.9.7 the bodega users aren't able to login anymore.
The patch fixes the issue.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This one is tricky in order to reproduce it.
There are 2 use cases which end up with a complete different result.
======> Use case 1 (discourse works)
You used to have a discourse installation of github.com/terietor/discourse and
then you updated the installation to github.com/aseigo/discourse and it works.
It works because terietor's discourse had written the write values in the table users.
So when some columns moved from the users table to the user_stats table your database
had the *right* values.
=====> Use case 2 (discourse fails)
You *don't* have an existing discourse installation and you setup github.com/aseigo/discourse.
You start the whole process from the begin and your users fail to login due to the "days_visited"
error. Why? Unlike the first use case the users table *doesn't* contain the columns of the user_stats table
so the user_stats table it never gets populated. Discourse assumes that the table contains the right values
and when the code is being executed the object is nill(NULL) so it fails.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>sql/discourse.plsql <span style="color: grey">(fdc0f01)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113347/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>